Prevent loading unsupported claim attributes for Non-JDBC primary user stores #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasinduYeshan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, when a tenant is created, claim attribute mappings from claim-config.xml are saved to the database for the primary user store domain. When a new user store is added, the mappings from the primary user store domain are used unless the admin explicitly creates new attribute mappings.
With this PR, we aim to avoid potential conflicts arising from unsupported attributes in non-JDBC primary user stores. Specifically, if the primary user store is LDAP or another unsupported user store, new attributes that aren't natively supported should not be loaded. Admin should set these mappings manually, providing better stability and reducing errors.
Related Issues