Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to set unicode strings through named params #34

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add support to set unicode strings through named params #34

merged 1 commit into from
Nov 6, 2024

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Oct 3, 2024 •
edited
Loading

UdeshAthukorala
UdeshAthukorala reviewed Oct 3, 2024
View reviewed changes
...database.utils/src/main/java/org/wso2/carbon/database/utils/jdbc/NamedPreparedStatement.java
*
* @param name Name of the index.
* @param value Value to be replaced.
* @throws SQLException SQL Exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add the missing full-stop here?

@darshanasbg darshanasbg merged commit eff3bb3 into wso2:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdeshAthukorala UdeshAthukorala UdeshAthukorala left review comments

@JKAUSHALYA JKAUSHALYA JKAUSHALYA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshanasbg @JKAUSHALYA @UdeshAthukorala