Introduce additional attribute json properties option #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
============================================
+ Coverage 28.40% 28.66% +0.26%
- Complexity 919 931 +12
============================================
Files 133 133
Lines 13007 13042 +35
Branches 2504 2505 +1
============================================
+ Hits 3695 3739 +44
+ Misses 8839 8830 -9
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sadilchamishka
previously approved these changes
Jan 20, 2025
sadilchamishka
previously approved these changes
Jan 20, 2025
|
PR builder started |
ashensw
reviewed
Jan 20, 2025
modules/charon-core/src/main/java/org/wso2/charon3/core/attributes/AbstractAttribute.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
jenkins-is-staging
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12861245257
DilshanSenarath
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current implementation of the scim2/Schemas response supports only string-based additional properties. To enhance flexibility and allow the inclusion of more complex data structures, this update introduces the ability to add JSON objects as first-class properties to the Schemas endpoint. This is particularly useful for returning properties such as attribute profiles, which require a structured JSON format.
Related Issues