Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DCR IS Implementations #306

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Adding DCR IS Implementations #306

merged 7 commits into from
Feb 5, 2025

Conversation

Ashi1993
Copy link
Contributor

@Ashi1993 Ashi1993 commented Jan 28, 2025 •
edited
Loading

Adding DCR IS Implementations

This PR adds DCR IS Implementations

Issue link: required

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

hasithakn
hasithakn reviewed Feb 5, 2025
View reviewed changes
...ervices/accelerator/identity/extensions/dcr/application/listener/ApplicationUpdaterImpl.java
String userName) throws FinancialServicesException {

try {
boolean updateAuthenticator = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to identify whether this doPreUpdateApplication is originated from DCR API? , or from updating UI authenticators?.

This is to stop re setting authenticators when we update from the UI.
( I think this issue still exists in OB3 as well )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a way to identify that for now. But I am checking the whether LocalAndOutBoundAuthenticationConfig is null or Authentications steps are null and set accordingly

aka4rKO
aka4rKO reviewed Feb 5, 2025
View reviewed changes
...ccelerator/identity/extensions/dcr/application/listener/FSApplicationManagementListener.java Outdated
try {
OAuthConsumerAppDTO oAuthConsumerAppDTO = DCRUtils
.getOAuthConsumerAppDTO(serviceProvider.getApplicationName());
oAuthConsumerAppDTO.setTokenType("JWT");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a recent fix done to this to be able to set a custom token type, shall we include that as well? @VimukthiRajapaksha did the fix for OB3 AFAIR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one,
#313

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ebbb3de

aka4rKO
aka4rKO reviewed Feb 5, 2025
View reviewed changes
...ccelerator/identity/extensions/dcr/application/listener/FSApplicationManagementListener.java Outdated

try {
AssociatedRolesConfig rolesConfig = new AssociatedRolesConfig();
rolesConfig.setAllowedAudience("ORGANIZATION");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add a comment on what is happening here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ebbb3de

aka4rKO
aka4rKO reviewed Feb 5, 2025
View reviewed changes
...ccelerator/identity/extensions/dcr/application/listener/FSApplicationManagementListener.java
throws IdentityApplicationManagementException {

try {
APIResourceManager resourceManager = IdentityExtensionsDataHolder.getInstance().getApiResourceManager();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add a comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ebbb3de

@aka4rKO aka4rKO merged commit 2d28f2b into wso2:main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akila94 Akila94 Akila94 left review comments

@hasithakn hasithakn hasithakn approved these changes

@aka4rKO aka4rKO aka4rKO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashi1993 @hasithakn @Akila94 @aka4rKO