Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accelerator 4] Adding JTI cache and DCR configurations #326

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[Accelerator 4] Adding JTI cache and DCR configurations #326

merged 4 commits into from
Feb 11, 2025

Conversation

Ashi1993
Copy link
Contributor

Adding JTI cache and DCR configurations

Explain in a few lines the purpose of this pull request

Issue link: required

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

Akila94
Akila94 reviewed Feb 10, 2025
View reviewed changes
.../java/org/wso2/financial/services/accelerator/identity/extensions/dcr/cache/JwtJtiCache.java Outdated
Comment on lines 50 to 55
public static synchronized JwtJtiCache getInstance() {
if (jwtJtiCache == null) {
jwtJtiCache = new JwtJtiCache();
}
return jwtJtiCache;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we implement double checked locking singleton instead of lazy initializing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7918c38

@Akila94 Akila94 merged commit 022b4ca into wso2:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akila94 Akila94 Akila94 approved these changes

@aka4rKO aka4rKO aka4rKO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashi1993 @Akila94 @aka4rKO