Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Idempotency Validation to consent management component #44

Merged
merged 18 commits into from
Mar 8, 2024

Conversation

Ashi1993
Copy link
Contributor

@Ashi1993 Ashi1993 commented Mar 4, 2024

Moving Idempotency Validation to consent management component #44

This PR moves idempotency validation from gateway to consent management component. Since distributed caching is deprecated idempotency validation is handles as a DB backed implementation.

Issue link: #47

Doc Issue: wso2/docs-open-banking#881

Applicable Labels: OB 3.0.0


Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. [ x Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

Copy link
Member

@Akila94 Akila94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the changes suggested in PR https://github.com/wso2-support/financial-open-banking/pull/3188 in this PR too.

@Ashi1993
Copy link
Contributor Author

Ashi1993 commented Mar 5, 2024

a20ff5a

Fixed in a20ff5a

@hasithakn hasithakn merged commit 9286661 into wso2:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants