Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCIM system schema #7362

Merged

Conversation

amanda-ariyaratne
Copy link
Contributor

Purpose

WSO2-related SCIM attributes that were previously part of the enterprise schema are now moved to the new System Schema. The existing custom schema is renamed as System schema. A new custom schema is added to maintain the separation between product related SCIM attributes and customer defined SCIM attributes.

In addition, all the usages of the attributes that were transitioned from the enterprise schema to the system schema are updated with the new schema URI.

Screenshot 2025-01-16 at 12 11 24

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@amanda-ariyaratne amanda-ariyaratne force-pushed the scim-system-schema-feature-2 branch from 8a81237 to 3fc3493 Compare January 22, 2025 17:58
@amanda-ariyaratne amanda-ariyaratne force-pushed the scim-system-schema-feature-2 branch from 3fc3493 to 46a593f Compare January 22, 2025 18:04
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.53%. Comparing base (3da35c9) to head (31b4e92).
Report is 81 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7362      +/-   ##
==========================================
+ Coverage   36.32%   36.53%   +0.21%     
==========================================
  Files          42       42              
  Lines         903      906       +3     
  Branches      223      223              
==========================================
+ Hits          328      331       +3     
- Misses        529      555      +26     
+ Partials       46       20      -26     
Flag Coverage Δ
@wso2is/core 36.53% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
modules/core/src/constants/profile-constants.ts 96.15% <100.00%> (+0.50%) ⬆️

... and 7 files with indirect coverage changes

@amanda-ariyaratne
Copy link
Contributor Author

Change year in the copyright license

public static readonly SCIM2_CORE_USER_SCHEMA: string = "urn:ietf:params:scim:schemas:core:2.0:User";
public static readonly SCIM2_ENT_USER_SCHEMA: string = "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User";
/**
Copy link
Contributor Author

@amanda-ariyaratne amanda-ariyaratne Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue for removeing the deprecated variables in future.
wso2/product-is#22376

JayaShakthi97
JayaShakthi97 previously approved these changes Jan 23, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@amanda-ariyaratne amanda-ariyaratne merged commit 71ee1c0 into wso2:master Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants