Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant logic after imp for coordination #3737

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public void memberAdded(NodeDetail nodeDetail) {
LOG.error("Exception occurred while resolving un assigned tasks upon member addition " + nodeDetail
.getNodeId(), e);
}
} else if (clusterCoordinator.getThisNodeId().equals(nodeDetail.getNodeId())
&& isMemberRejoinedAfterUnresponsiveness()) {
// This node became unresponsive and rejoined the cluster hence removing all tasks assigned to this node
// then start the scheduler again after cleaning the locally running tasks.
becameUnresponsive(nodeDetail.getNodeId());
reJoined(nodeDetail.getNodeId(), null);
}
}

Expand Down Expand Up @@ -134,15 +128,6 @@ public void becameUnresponsive(String nodeId) {
}
}

/**
* Check whether the member has rejoined after being unresponsive.
*
* @return true if the member has rejoined after being unresponsive, false otherwise
*/
public boolean isMemberRejoinedAfterUnresponsiveness() {
return taskManager.getLocallyRunningCoordinatedTasks().size() > 0;
}


@Override
public void reJoined(String nodeId, RDBMSMemberEventCallBack callBack) {
Expand Down
Loading