Better error validation for CRX package manager tools #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinus
changed the title
jwadolowski
reviewed
Oct 24, 2019
| @@ -109,8 +109,12 @@ do | |||
| STATUS=$(echo "${STATUS}" | sed '$d') | |||
| "${API}" -H "${STATUSCODE}" | |||
| EXITCODE2=${?} | |||
| if [ "${EXITCODE}" -ne 0 -o "${EXITCODE2}" -ne 0 ] | |||
| INNERHTTPCODE=$(echo "${STATUS}" | xmllint --xpath "string(//status/@code)" -) | |||
There was a problem hiding this comment.
This assumes that xmllint is installed, which may not be the case.
The general idea behind CQ UNIX Toolkit was to avoid external dependencies and rely on built-in commands only (curl, sed, etc).
PS I know that parsing XMLs with sed doesn't sound like fun :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures cqput and cqrun return without success (
returncode != 0) when the response from CQ contains inner HTTP code different than200.References issue #24