Features 376 381 412 #417
Merged
Features 376 381 412 #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cogboard-app/src/main/kotlin/com/cognifide/cogboard/CogboardConstants.kt
janeksmielowski
approved these changes
Nov 10, 2021
| // send(JsonObject().put("logs", logs)) | ||
| } | ||
|
|
||
| // private fun createTemplateLogs(n: Int): JsonArray { |
There was a problem hiding this comment.
co to za komentarze? wyrzućmy, żeby nie śmiecić kodu
| private fun determineLogParsingStrategy() = | ||
| LogParserStrategyFactory() | ||
| .build(LogParserStrategyFactory.MOCK) | ||
| /* temporary solution, we'll have to decide if we'll get information of log types from |
| import com.cognifide.cogboard.widget.type.logviewer.logparser.ParsedLog.Companion.PROVIDER | ||
| import com.cognifide.cogboard.widget.type.logviewer.logparser.ParsedLog.Companion.MESSAGE | ||
|
|
||
| class MockLogParserStrategy : LogParserStrategy() { |
There was a problem hiding this comment.
Nie wiem, czy MockLogParserStrategy to odpowiednia nazwa? Czy format logów, które tworzymy w logu trzyma się jakiejś konwencji, czy jest z czapy?
There was a problem hiding this comment.
Nie bardzo jestem w stanie znaleźć jakiej konwencji mógłby się trzymać ten format logów, stąd nazwa klasy. Dotyczy stricte tych logów, które są generowane w mocku
|
|
||
| override fun parseLine(logLine: String): JsonObject { | ||
| val groups = regex.matchEntire(logLine.trim())?.groups | ||
| // ?: throw LogParsingException("Unable to parse line: $logLine") |
There was a problem hiding this comment.
co z tym wyjątkiem?
| const reader = new FileReader(); | ||
| reader.onload = async e => { | ||
| const text = e.target.result; | ||
| let event = e; |
There was a problem hiding this comment.
dlaczego od razu nie nazwiemy argumentu "event"?
| const deleteFile = e => { | ||
| e.preventDefault(); | ||
| setFilename(''); | ||
| let event = e; |
TheTerabit
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
#412, old pr: #415
#381, old pr: #413
#376
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.