Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests #22

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Write unit tests #22

merged 3 commits into from
Sep 2, 2022

Conversation

andrzej-krzemien
Copy link
Collaborator

Issue : #1

Description

  • Add new directory for test classes
  • Add StubFinderServiceTest and StubResponseTest class
  • Adding dependencies to pom.xml in core package

Types of Changes

  • New feature

Tasks

  • Review changes

Review

  • Tests

Deployment Notes

N/A

@andrzej-krzemien
Issue : #1
bf74e51 
## Description
- Add new directory for test classes
- Add StubFinderServiceTest and StubResponseTest class
- Adding dependencies to pom.xml in core package

## Types of Changes
- New feature

## Tasks
- [ ] Review changes

## Review
- [ ] Tests

## Deployment Notes
N/A
@andrzej-krzemien andrzej-krzemien self-assigned this Jul 22, 2022
renata-zuranska-wttech
renata-zuranska-wttech reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@renata-zuranska-wttech renata-zuranska-wttech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New unit tests fails with error: java.lang.NoClassDefFoundError: com/google/gson/internal/bind/JsonTreeReader

Add the following to pom.xml:

	        <dependency>
			<groupId>com.google.code.gson</groupId>
			<artifactId>gson</artifactId>
			<version>2.8.6</version>
			<scope>test</scope>
		</dependency>`

to fix it

core/pom.xml Outdated Show resolved Hide resolved
core/src/test/java/io/wttech/stubway/response/StubResponseTest.java Outdated Show resolved Hide resolved
core/src/test/java/io/wttech/stubway/response/StubResponseTest.java Outdated Show resolved Hide resolved
@andrzej-dolinski-wttech andrzej-dolinski-wttech merged commit 5f7331d into main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-dolinski-wttech andrzej-dolinski-wttech andrzej-dolinski-wttech approved these changes

@renata-zuranska-wttech renata-zuranska-wttech renata-zuranska-wttech approved these changes

@piotr-rogacki-wttech piotr-rogacki-wttech piotr-rogacki-wttech approved these changes

Assignees

@andrzej-krzemien andrzej-krzemien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrzej-krzemien @piotr-rogacki-wttech @renata-zuranska-wttech @andrzej-dolinski-wttech