Restore login session upon reload #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, credentials get stored in the `sessionStorage` in an obfuscated way upon login. When the login route gets loaded, the application trys to automatically sign in using any stored credentials. Credentials (and thus, the login session) are automatically once either: 1. the tab/browser gets closed (cf. https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage), or 2. the `logout()` function gets called (e.g., when the user logs out manually), or 3. a login attempt with the stored credentials fails. This significantly improves the user experience since refreshing pages works without any issues, now. Also, the developer experience is significantly improved as developers no longer need to sign back in everytime a reload happens during development.
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, credentials get stored in the
sessionStoragein an obfuscated way upon login.When the login route gets loaded, the application trys to automatically sign in using any stored credentials.
Credentials (and thus, the login session) are automatically once either:
logout()function gets called (e.g., when the user logs out manually), orThis significantly improves the user experience since refreshing pages works without any issues, now.
Also, the developer experience is significantly improved as developers no longer need to sign back in everytime a reload happens during development.