Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shell REPL, suppress unnecessary output + Disable unsupported child menus #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

svartkanin
Copy link

@svartkanin svartkanin commented Jun 9, 2017

COMMIT 1:

I realized when opening a Shell REPL a bunch of unnecessary output and weird characters:

bash: cannot set terminal process group (11708): Inappropriate ioctl for device
bash: no job control in this shell
�]0;user@hostname: ~/.config/sublime-text-3/Packages/SublimeREPL/repls�user@hostname:~/.config/sublime-text-3/Packages/SublimeREPL/repls$

The bash errors seem to occur because the bash is not running in a TTY and can therefore no process group can be registered. The bash still works as expected but the output is not necessary and can be suppressed since this is not something that can be fixed anyhow (at least not to my knowledge).
The first added regex will therefore filter these errors out so that they are not displayed angain.

The actual Primary Prompt String (PS1) showed some very odd hex characters (\x1b, \x07) and in between I got a PS1 which doesn't quite fulfill the specs from the .bashrc file. After the \x07 the actual defined PS1 is written. Therefore, the second regex will filter the odd hex characters and the PS1 in between them away.

COMMIT 2:
If programs are not installed on an OS and clicking the menu option for it will result in an error thrown when creating the Popen pipe.
To stop that from happening, the menu entries that are not currently supported by the OS should be disabled.

@svartkanin svartkanin changed the title Update Shell REPL, suppress unnecessary output Update Shell REPL, suppress unnecessary output + Disable unsupported child menus Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant