Skip to content
This repository has been archived by the owner on Jan 25, 2019. It is now read-only.

Return nil when link data is nil #197

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MihranDovlatyan
Copy link

@MihranDovlatyan MihranDovlatyan commented Oct 17, 2017

In
fileprivate func extractToOneRelationship( key: String, from serializedData: JSON, linkedType: ResourceType) -> Resource?
function if linkData["data"] is nil, then type becomes equal to linkedType.
In next lines if resourceFactory.dispense() or resourceFactory.instantiate() thrown an error on type value, then they will crash on linkedType in catch block.

@MihranDovlatyan
Copy link
Author

Please check this Travis fails when data is nil.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant