[NUOPEN-215][Shared dev] Show duration in days for Daily Rate Instruments #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeticiaErrandonea
force-pushed
the
nuopen-215-daily_rate_in_days
branch
from
b2f3b08 to
b666cba
Compare
diebas
approved these changes
Feb 19, 2025
app/support/price_displayment.rb
Outdated
| @@ -94,6 +94,9 @@ def build_quantity_presenter | |||
| else | |||
| quantity | |||
| end | |||
|
|
|||
| quantity_to_display /= (24 * 60) if product.is_a?(Instrument) && product.daily_booking? | |||
There was a problem hiding this comment.
Nit: I feel the logic of this method can be separated but is nothing critical.
| @@ -91,6 +91,16 @@ def actual_duration_mins(actual_end_fallback: nil) | |||
| end | |||
| end | |||
|
|
|||
| def actual_duration_days(actual_end_fallback: nil) | |||
There was a problem hiding this comment.
NIT: I'm not big fan of elsifs, but I'm ok with whatever way you feel is more legible.
def actual_duration_days(actual_end_fallback: nil)
return @actual_duration_days.to_i if @actual_duration_days
return TimeRange.new(actual_start_at, actual_end_at || actual_end_fallback).duration_days if actual_start_at
0
end
There was a problem hiding this comment.
I replicated the logic for actual_duration_mins
| @@ -29,9 +29,19 @@ | |||
| %td.order_date | |||
| = od.ordered_at&.strftime("%m/%d/%Y") | |||
|
|
|||
| %td.currency.timeinput= od.reservation.try(:duration_mins) | |||
| - daily_booking_product = od.product.is_a?(Instrument) && od.product.daily_booking? | |||
There was a problem hiding this comment.
This check is repeated a couple of times, and I feel it might be used again in the future. Should we add it as a method in the product model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Screenshot
Order receipt
Order view