Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagically reduce MH effect to match number of configured fixtures. #4699

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cybercop23
Copy link
Collaborator

This allowes for easy import from 8->6 or 8->4 without the need to adjust each effect.
When the new effect is used right, after an import to less number of heads you'd have to do a dummy/fake change to get them to recalc and readjust to the lesses number of heads. Now,. you don't need to do that.

@MrPierreB
Copy link
Contributor

I think rather than implement half or temporary solution we need to think of a more complete solution to mapping from the source sequence to our layouts. Not only going from 8 to less, but also from 4 to more - and also fixing existing issues on the import.
Looking at the code in this PR, there is a lot of string manipulation happening and also some magic numbers like substr 13, which usually isn't the greatest as when anything changes somewhere else it will start causing this to fail. Also there is no error handling so if it does fail, we don't want it to break imports completely.
I haven't run the code, but from looking at it I think there might actually be a bug here as well, when you write Heads: back - the values i suspect might not be correct if you map for example a single moving head effect placed directly on moving head 7, to your layout which only has 4 heads, and you mapped their moving
head 7 to your moving head 3.

There is also the existing bug that if you for example map over moving head effects that are directly on MovingHead4 to your Moving Head 3 and you save - in the xml you will see the effect still has Heads: 4 so when you render and play, the moving head will not move as if the effect is not there. Only when you click on the actual effect in the sequencer does it autocorrect, and then when you save it has Heads: 3. Have to click on each effect one by one.

@AzGilrock @dkulp
Open to discussion on ideas here - One way I think could be on the mapping screen, once you did your mapping selection and click ok, it checks if any of the source effects will be moving heads, if so it shows a new 2nd window that asks how you would like to map over x number of moving heads to your y number of heads.
This way you will have the x to y mappings so you can correctly set the Heads: property and also you can copy the effects on E_TEXTCTRL_MH from the correct option to the correct destination.. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants