Skip to content

Commit

Permalink
[dotnet] Call the _CreateAssetPackManifest target during the build. F…
Browse files Browse the repository at this point in the history
…ixes #19669. (#19681)

We're calling the _CreateAssetPackManifest target during the build for legacy
Xamarin apps, but somehow this seems to have been skipped over when
implementing .NET support.

The reason this has not showed up before is that it requires:

* OnDemand resources.
* An AdHoc provisioning profile (and a distribution certificate).

The last part makes it rather complicated to write a unit test, so this has
been verified manually.

Fixes #19669.
  • Loading branch information
rolfbjarne authored Jan 2, 2024
1 parent c51943a commit f4ad798
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
_CopyResourcesToBundle;
_CompileCoreMLModels;
_CreatePkgInfo;
_CreateAssetPackManifestMobile;
_SmeltMetal;
_TemperMetal;
_DetectAppManifest;
Expand Down Expand Up @@ -273,6 +274,8 @@
</CreateAppBundleDependsOn>
</PropertyGroup>

<Target Name="_CreateAssetPackManifestMobile" Condition="'$(_PlatformName)' != 'macOS'" DependsOnTargets="_CreateAssetPackManifest" />

<!-- PublishTrimmed must be calculated as part of a target because IsMacEnabled on Windows will be set after connecting to the Mac -->
<Target Name="_ComputePublishTrimmed">
<PropertyGroup>
Expand Down

6 comments on commit f4ad798

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.