Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Disable CodeQL on pull requests. #21956

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[CI] Disable CodeQL on pull requests. #21956

wants to merge 7 commits into from

Conversation

mandel-macaque
Copy link
Member

Disable CodeQL on pull requests to remove the chance of duplicated reports.

@mandel-macaque
[CI] Disable CodeQL on pull requests.
e4cffbc 
Disable CodeQL on pull requests to remove the chance of duplicated
reports.
mcumming
mcumming requested changes Jan 13, 2025
View reviewed changes
tools/devops/automation/build-pipeline.yml Outdated
@@ -220,6 +220,10 @@ extends:
- repository: yaml-templates
- repository: sdk-insertions
- repository: macios-adr # macios-adr has it's own build pipeline and should not be included in the source analysis
codeql:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the build-pr-pipeline.yml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, was too early, I'll update that

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

rolfbjarne
rolfbjarne approved these changes Jan 13, 2025
View reviewed changes
tools/devops/automation/build-pull-request.yml Outdated Show resolved Hide resolved
tools/devops/automation/build-pull-request.yml Outdated
Comment on lines 204 to 208
- repository: maccore
exclude:
- repository: yaml-templates
- repository: sdk-insertions
- repository: macios-adr # macios-adr has it's own build pipeline and should not be included in the source analysis
- repository: yaml-templates
- repository: sdk-insertions
- repository: macios-adr # macios-adr has it's own build pipeline and should not be included in the source analysis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the indentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yamllint would complain and would make the build fail. Remember we added it to be ran only in modified files. I have a vim plugin that tells me before I get a failed build.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 109 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e4cffbc25c2851b6121b7d96b12a933ef4587334 [PR build]

stephen-hawley
stephen-hawley approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@stephen-hawley stephen-hawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar nit

tools/devops/automation/build-pull-request.yml Outdated
- repository: macios-adr # macios-adr has it's own build pipeline and should not be included in the source analysis
- repository: yaml-templates
- repository: sdk-insertions
- repository: macios-adr # macios-adr has it's own build pipeline and should not be included in the source analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's (contraction of "it is") -> its (possessive of "it")

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed (Build macOS tests) 🔥

Build failed for the job 'Build macOS tests' (with job status 'Failed')

Pipeline on Agent
Hash: d775b9935dc3257c52dc14f8a70c2e6d60cd60d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed (Detect API changes) 🔥

Build failed for the job 'Detect API changes' (with job status 'Failed')

Pipeline on Agent
Hash: d775b9935dc3257c52dc14f8a70c2e6d60cd60d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed (Build packages) 🔥

Build failed for the job 'Build packages' (with job status 'Failed')

Pipeline on Agent
Hash: d775b9935dc3257c52dc14f8a70c2e6d60cd60d1 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcumming mcumming mcumming approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @stephen-hawley @mcumming