Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Drop support for python 3.9 and older #26

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions coeus_sphinx_theme/extensions/notebook.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Author: Akshay Mestry <[email protected]>
Created on: Wednesday, October 09 2024
Last updated on: Tuesday, October 29 2024
Last updated on: Wednesday, November 27 2024

This module provides a custom directive for the Coeus Sphinx Theme,
that allows authors and contributors to embed a Jupyter Notebook or a
Expand Down Expand Up @@ -87,7 +87,8 @@ def run(self) -> list[nodes.Node]:
base = self.options.get("basedir", "_jupyter")
flags: str = ""
if self.content:
url = f"../{base}/notebooks/?path={'\n'.join(self.content)}"
content = "\n".join(self.content)
url = f"../{base}/notebooks/?path={content}"
if not self.content:
url = f"../{base}/repl/index.html?"
flags += "kernel=python&toolbar=1"
Expand Down
23 changes: 15 additions & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "coeus-sphinx-theme"
dynamic = [ "version", "dependencies" ]
description = "A Sphinx Documentation Theme."
readme = "README.rst"
requires-python = ">=3.8"
requires-python = ">=3.10"
license.file = "LICENSE"
authors = [
{ name = "Akshay Mestry", email = "[email protected]" }
Expand All @@ -20,8 +20,6 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand Down Expand Up @@ -69,10 +67,21 @@ disable_error_code = ["attr-defined", "index", "union-attr"]

[tool.tox]
requires = ["tox>=4"]
envlist = ["py312", "py311", "py310", "py39", "py38", "static"]
envlist = ["py312", "py311", "py310"]

[tool.tox.env.static]
deps = ["-r requirements-dev.txt"]
[tool.tox.env_run_base]
description = "Linting code and running static type checking on {base_python}"
deps = [
"black",
"docutils-stubs",
"flake8",
"isort",
"mypy",
"mypy-extensions",
"types-beautifulsoup4",
"types-docutils",
"typing_extensions",
]
commands = [
["black", "-q", "coeus_sphinx_theme/"],
["flake8", "coeus_sphinx_theme/"],
Expand All @@ -85,5 +94,3 @@ commands = [
"3.12" = ["3.12"]
"3.11" = ["3.11"]
"3.10" = ["3.10"]
"3.9" = ["3.9"]
"3.8" = ["3.8"]
9 changes: 0 additions & 9 deletions requirements-dev.txt

This file was deleted.

1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ sphinx-tags
sphinx_design
sphinxcontrib-jquery
sphinxext-opengraph
tox