CP-45750 Allow for alternative local storage SR types #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2024 15:27
Unit test for storage-init, to guard against breakage from 4kn local storage work. Signed-off-by: Robin Newton <[email protected]>
storage-init no longer silently ignores unrecognized SR types, but instead handles them in the same way as 'lvm' and 'ext' (the handling of which has now been unified). This presupposes that an SR type specified in first-boot configuration will take a single configuration parameter - 'device' - which is a comma-separated list of partitions - which is what 'lvm' and 'ext' do. Signed-off-by: Robin Newton <[email protected]>
MarkSymsCtx
previously approved these changes
Mar 26, 2024
KevinLCtx
previously approved these changes
Mar 26, 2024
* storage-init itself contains bashisms, so in the tests don't try to run it with sh * bash run under its own name seems a bit resistent to attempts to redefine '[', so instead manipulate storage-init to subsistute uses of this for a mockable alternative. Signed-off-by: Robin Newton <[email protected]>
MarkSymsCtx
approved these changes
Mar 26, 2024
KevinLCtx
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.