Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of new fair locking subsystem #685

Merged

Conversation

TimSmithCtx
Copy link
Contributor

Wrap calls to commands which need to access the device mapper in a context manager for a resource called "device-mapper" so that they get serialised in a fair manner (no queue-jumping like a lockfile would have).

@MarkSymsCtx MarkSymsCtx requested a review from rdn32 May 7, 2024 12:04
MarkSymsCtx
MarkSymsCtx previously approved these changes May 7, 2024
KevinLCtx
KevinLCtx previously approved these changes May 7, 2024
@TimSmithCtx TimSmithCtx dismissed stale reviews from KevinLCtx and MarkSymsCtx via 6086a8e May 7, 2024 14:00
@TimSmithCtx TimSmithCtx force-pushed the private/timsmi/CA-387861 branch from 7de984d to 6086a8e Compare May 7, 2024 14:00
@TimSmithCtx
Copy link
Contributor Author

Using a "-" in the resource name causes the socket name to contain a "/" after being passed through systemd's substitutions, which causes All Sorts Of Trouble, so don't do that...

@TimSmithCtx TimSmithCtx merged commit 0ac8e84 into xapi-project:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants