CA-395560 Improve logging and error checking on sg_readcap #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading information using sg_readcap, it would be useful in the event of failure to log what the return code was so that we know what failure we're dealing with. Also, per the manual pages for these commands, there are quite a few more return codes which should be considered retryable, plus a non-zero success return code which is theoretically possible. Add a function to gather up the checks and logs for these things and then wrap a call to that function in a short retry loop. Signed-off-by: Tim Smith <[email protected]>
KevinLCtx
approved these changes
Feb 18, 2025
MarkSymsCtx
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading information using sg_readcap, it would be useful in the event of failure to log what the return code was so that we know what failure we're dealing with.
Also, per the manual pages for these commands, there are quite a few more return codes which should be considered retryable, plus a non-zero success return code which is theoretically possible.
Add a function to gather up the checks and logs for these things and then wrap a call to that function in a short retry loop.