CP-48195: Split tracing library to avoid future cyclic dependencies
#5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Apr 9, 2024
psafont
reviewed
Apr 9, 2024
psafont
reviewed
Apr 9, 2024
psafont
reviewed
Apr 9, 2024
mg12
reviewed
Apr 9, 2024
mg12
reviewed
Apr 9, 2024
mg12
reviewed
Apr 9, 2024
mg12
reviewed
Apr 9, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-48195-v2
branch
2 times, most recently
from
97f0194 to
874ffc8
Compare
psafont
reviewed
Apr 10, 2024
lindig
reviewed
Apr 10, 2024
ocaml/forkexecd/lib/forkhelpers.ml
Outdated
| @@ -357,10 +362,12 @@ let execute_command_get_output_inner ?env ?stdin ?(syslog_stdout = NoSyslogging) | |||
| ) | |||
| (fun () -> List.iter Unix.close !to_close) | |||
|
|
|||
| let execute_command_get_output ?env ?(syslog_stdout = NoSyslogging) | |||
| let execute_command_get_output ?traceparent ?env ?(syslog_stdout = NoSyslogging) | |||
There was a problem hiding this comment.
Is traceparent written this way in other code already? Otherwise I would prefer a better spelling.
There was a problem hiding this comment.
There are some places that call the parent span traceparent, some that call it parent, some that call it tracing. Given the function used is called with_tracing is it more preferable to call it tracing?
ocaml/forkexecd/lib/forkhelpers.ml
Outdated
| @@ -357,10 +362,12 @@ let execute_command_get_output_inner ?env ?stdin ?(syslog_stdout = NoSyslogging) | |||
| ) | |||
| (fun () -> List.iter Unix.close !to_close) | |||
|
|
|||
| let execute_command_get_output ?env ?(syslog_stdout = NoSyslogging) | |||
| let execute_command_get_output ?traceparent ?env ?(syslog_stdout = NoSyslogging) | |||
There was a problem hiding this comment.
Is traceparent written this way in other code already? Otherwise I would prefer a better spelling.
ocaml/libs/tracing/tracing.mli
Outdated
| module Attributes : sig | ||
| type 'a t | ||
|
|
||
| val fold : (string -> 'a -> 'b -> 'b) -> 'a t -> 'b -> 'b |
There was a problem hiding this comment.
This smells funny. We have a new abstract type 'a t that has no way to create or observe it.
psafont
reviewed
Apr 10, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-48195-v2
branch
from
031bce8 to
ac1baee
Compare
GabrielBuica
changed the title
forkhelpers.ml with dttracing library to avoid future cyclic dependencies
lindig
reviewed
Apr 17, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-48195-v2
branch
from
bcc563a to
ee9906b
Compare
psafont
approved these changes
Apr 19, 2024
Attempts to split the tracing library into components and exporter parts. While trying to instrument `forkhelpers.ml` with tracing, I found a cycle dependency: `Tracing(Exporter)` -> `Open_uri` -> `Stunnel` -> `Forkhelpers`. This splits the tracing library between exporting functionality and components. Signed-off-by: Gabriel Buica <[email protected]>
Small improvements to `tracing_export.ml` and `tracing_exoprt.mli`. Issues found while splitting the library such as: missing documentation and small code refactoring for better readability. Signed-off-by: Gabriel Buica <[email protected]>
Adds `with_tracing` helper function to `forkhelpers.ml`. This is to show that there are no more cycle dependecies between `tracing` library and `forexecd` and it will be used in a follow-up PR to instrument `forkhelpers` with tracing. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/CP-48195-v2
branch
from
ee9906b to
d049d43
Compare
|
BVT 197315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to split the
tracinglibrary in 2 parts:tracing.mlthat represents the core of the library;tracing_export.mlthat creates and manages the exporter thread.This is to avoid cyclic dependencies between
tracingandforkexecd.Instrumentation of
forkexecdwill be done as a follow-up PR.