CA-388210: use unique datapaths for concurrent VDI copies #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter was passed through unchanged. However VDI.epoch_begin/epoch_end doesn't actually need it, so drop it. We intend to change how we compute the 'domain' parameter, and VDI.epoch_begin/end wouldn't have sufficient information to compute it anymore. No functional change. Signed-off-by: Edwin Török <[email protected]>
We are going to change how we compute it, so factor it out into a function. No functional change. Signed-off-by: Edwin Török <[email protected]>
…ument as domain for Dom0 Dom0 allows multiple attaches of RO disks, used e.g. for VDI.copy. Send a unique value to SMAPIv3 plugins to avoid bugs to the lack of reference counting in those plugins. XAPI already sends a unique value here, either vbd/domid/device, or a fresh UUID (for storage migration). Signed-off-by: Edwin Török <[email protected]>
It is believed that the deadlocks in SMAPIv3 were caused by VDI.copy operations that attach the same disk RO multiple times in Dom0. With the previous commits we now use a unique identifier and spawn a separate qemu-dp process in the SMAPIv3 plugins, which should prevent the deadlocks and IO errors due to lack of refcounting. Signed-off-by: Edwin Török <[email protected]>
…ath argument as domain for Dom0
lindig
approved these changes
Sep 18, 2024
| or vbd/domid/device. | ||
| For regular guests keep the domain as passed by XAPI (an integer). | ||
| *) | ||
| let domain_of ~dp ~vm' = |
There was a problem hiding this comment.
Requiring a prime in named label is a bit awkward - is there a reason this is not just ~vm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on a box shows that the new unique arguments for 'domain' work, but opening as a draft PR, because this needs wider testing in XenRT.