CA-404512: Add feature flag to the new clustering interface #6217
Conversation
|
This is likely end up being a high priority push, so once this is reviewed and merged into master, I will find an appropriate tag onto which we can base this commit (probably 24.39.0), and then make a release out of it. |
Is this how this works? Would we then have to rebase the current master on top of this commit+24.39.0 since otherwise history would not make sense? |
Vincent-lau
force-pushed
the
private/shul2/ch-flag
branch
from
74886de to
b6a8dcc
Compare
|
This PR would need to be merged alongside with a v6 PR, which introduces the new |
|
Do we have a problem when updating a pool from an older version that already uses the extended address type? I think it tend reverts to non-extended temporarily during the update... is that going to go wrong? |
Yes good point. I think this should be fine, as the clustering interface is defined and known to all hosts that is using the extended address, and even if one of them revert to the old address type, other hosts that have not applied this patch would still be able to understand that. Alternative would be to just keep using the cluster_health feature flag, instead of the new cluster_address feature flag, which will make sure those who know this interface will keep using it |
ocaml/xapi/xapi_cluster.ml
Outdated
| if Xapi_cluster_helpers.cluster_address_enabled ~__context then | ||
| Extended | ||
| { | ||
| ip= Ipaddr.of_string_exn (ipstr_of_address ip_addr) | ||
| ; hostuuid | ||
| ; hostname | ||
| } | ||
| else | ||
| IPv4 (ipstr_of_address ip_addr) |
There was a problem hiding this comment.
I see this piece of code also used below, can we add a util in Xapi_cluster_helpers for this?
The new clustering interface uses a constructor `Extended` address when a cluster hots is trying to join a cluster. This causes problems during upgrades as a newly upgraded host might send out the new address format to old hosts, which do not understand this format, causing the new hosts not able to join. The fix would be to use a new cluster_address feature flag/pool restrictions to control the use of the new clustering interface. This makes sure that the new interface would only be used if all of the hosts understand this new interface, i.e. have this feature enabled. The cluster_address feature is controlled by v6d and is pool-wide, therefore the new interface would only be enabled if all v6ds are updated to the correct level, which also implies that the accompanying xapi are updated to the correct level. Signed-off-by: Vincent Liu <[email protected]>
Vincent-lau
force-pushed
the
private/shul2/ch-flag
branch
from
b6a8dcc to
02ca33e
Compare
The new clustering interface uses a constructor
Extendedaddress when a cluster hots is trying to join a cluster. This causes problems during upgrades as a newly upgraded host might send out the new address format to old hosts, which do not understand this format, causing the new hosts not able to join.The fix would be to use the cluster_health feature flag/pool restrictions to gate the use of the new clustering interface. This makes sure that the new interface would only be used if all of the hosts understand this new interface, i.e. have this feature enabled. The cluster_health feature is controlled by v6d and is pool-wide, therefore the new interface would only be enabled if all v6ds are updated to the correct level, which also implies that the accompanying xapi are updated to the correct level.