This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Moves Tree Contents so that simpsons data tree in example is defined. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes :py:meth => :py:class since it's a property not a method.
|
Thanks @flamingbear. FYI the reason I added the content about "hollow trees" was in preparation for #271. |
TomNicholas
approved these changes
Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of #300 because I nuked my fork without thinking.
Since I'm reading the docs and don't know sphinx very well, I saw a problem with the is_hollow description and fixed it.
It may make more sense to have Tree Contents: Hollow Trees above Manipulating Trees: Subsetting Tree Nodes, but the simpsons DataTree is undefined. Rather than create a new tree for this example I just moved it.
In addition to moving it I changed the description from a python method to the py:class so that the rendering didn't include the incorrect parens.
The updated docs after rebuilding show the tree is not hollow rather than NameError: name 'simpsons' is not defined as it did before
New image generated:
Also increased clarity of the
dt.match()operation by printing the result.And fixed a typo.
wo=>twoj