-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracing] Propagate TraceID to the backend. Create a new setupEnv span. Fix span hierarchy #604
base: main
Are you sure you want to change the base?
Conversation
|
size-limit report 📦
|
Your pull request has been published to npm. You can install it by running:
To test the CLI, run:
|
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
@@ -1,19 +1,32 @@ | |||
export type AttributeDictionary = Record<string, string | number | boolean | undefined>; | |||
|
|||
export type SetAttributesFn = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is unused it seems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these are publicly exported types, so doesn't matter if we don't use them internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgirones Give it a try please!
Looking good! The hierarchy of spans is maintained till the backend 👌 One downside with the final refactor is that we lost the parent Span, and now we have a bunch of top-level spans that belong to the same suite but we don't have a way to point to "all of them". |
I will look at it! Thanks @sgirones |
This PR tackles three main issues:
span
for the setup actions: this change traces the setup actions performed by everytest suite
and links thesetup span
to thesuite span
TODO:
test case
are linked to thesuite span
instead of thetest span
. The test span created in thebeforeEach
hook needs to be activated before the test code runs.