Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin.amber] v3.50.02 #446

Merged
merged 1 commit into from
May 12, 2024
Merged

[skin.amber] v3.50.02 #446

merged 1 commit into from
May 12, 2024

Conversation

MikeSiLVO
Copy link

Description

Updating Amber for Nexus. With bartolomesoriano's permission.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@MikeSiLVO
Copy link
Author

I see the error but I do not see where the issue actually is.
Any pointers would be appreciated since it looks like a zipped after the fact problem.

Thanks.

@ronie
Copy link
Member

ronie commented May 12, 2024

doesn't look related to your skin, so let's ignore it for now :)

came across a few things to check though:

Variable not defined: EpisodeTitleVar
1080i/View_502_RightList.xml: line 2035

Variable not defined: TitleColorVar
1080i/View_502_RightList.xml: line 2037

Variable not defined: InfoWallBottomLabel1Var
1080i/View_502_RightList.xml: line 2046

Variable not defined: ListAlbumVar
1080i/View_502_RightList.xml: line 2056

Variable not defined: TitleColorVar
1080i/View_502_RightList.xml: line 2084

Variable not defined: TitleColorVar
1080i/View_502_RightList.xml: line 2096

Variable not defined: InfoWallBottomLabel1Var
1080i/View_502_RightList.xml: line 2107

Variable not defined: InfoWallTextboxVar
1080i/View_502_RightList.xml: line 2116

@MikeSiLVO
Copy link
Author

I thought I commented all of those out. I'll take a look when I get home 😄

I wasn't sure if Bart was in the middle of adapting the code to Amber or not so didn't want to just delete it.

@ronie
Copy link
Member

ronie commented May 12, 2024

ah that could be, my automated script might have missed that.

@ronie
Copy link
Member

ronie commented May 12, 2024

nope, they are still there.

@MikeSiLVO
Copy link
Author

I can’t double check the PR files. GitHub mobile is crap lol

The entire include should be commented out

https://github.com/MikeSiLVO/skin.amber/blob/master/1080i/View_502_RightList.xml#L2016

@ronie
Copy link
Member

ronie commented May 12, 2024

confirmed, must've been a brainfart.

@ronie ronie merged commit 6bdc5e5 into xbmc:nexus May 12, 2024
1 check failed
@MikeSiLVO
Copy link
Author

Thanks, ronie 😃

@MikeSiLVO MikeSiLVO deleted the amber_nexus branch June 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants