-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for checking the compatibility of schema version and xcat release #71
Conversation
@immarvin I don't know all the details but just trying to comment on the above... right now most of our schema version is 1.0...
In this case, are we able to import using any version of xcat-inventory? This is what I would like to solve... What is required in schema version 2.0 and what is required in 3.0 ? Since I will never export again, i will never update my schema version in the source control.... Maybe the import should be looking for keywords that related to schema changes... for example, if GITREPO is specified, it's at a newer version ,and then we should do the checking and block if xCAT is not at a supported version that required... Otherwise do not block import. One big problem here is that for my use case, I don't see us doing
How would we ever update the schema version of the json or yaml? |
hi @whowutwut , here is a summary of the scenarios that a new schema version(
So on your question,
I think if the DB fields involved in osimage definition does not go beyond the DB schema in xCAT, the osimage definitions can always be imported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do an enhancement later to figure out which schema is compatible for a specified inventory file.
fix issue:
#67
#69
key modifications:
behavior changes:
xcat-inventory import
will pickup the schema file according to the "schema_version" in the inventory file, then validate whether the schema file is compatible with the xCAT version on management server.xcat-inventory export
will pick up the most updated valid schema version for the xCAT version on management server and export the inventory data, the schema version will also be added in the inventory data/fileUT: