Don't fail seeing a backup refering to non-existent disk #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
approved these changes
Oct 4, 2023
stormi
reviewed
Oct 4, 2023
Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
inexistant-disks
branch
from
5d6d617 to
6a9b16c
Compare
stormi
reviewed
Oct 5, 2023
product.py
Outdated
| backup.version <= THIS_PLATFORM_VERSION: | ||
| if backup.version < XENSERVER_MIN_VERSION: | ||
| logger.log("findXenSourceBackups: ignoring, platform too old: %s < %s" % | ||
| (backup.version, XENSERVER_MIN_VERSION)) |
There was a problem hiding this comment.
Should be indented like line 545?
There was a problem hiding this comment.
At first I thought your remark was about the different indent wrt if of line 537.
This indeed made me focus on the role of these nested if's: as an extra condition for the whole nominal path, it makes a case for getting back to the lightweight try:except in my original refactor (idiom akin to goto fail error paths in C)
ydirson
force-pushed
the
inexistant-disks
branch
from
6a9b16c to
9771df0
Compare
- it is bad practice to "catch any" - not logging anything just hides information, which can be especially important here as the reason for a try/catch is not obvious (exceptions thrown by XenServerBackup.__init__?) Signed-off-by: Yann Dirson <[email protected]>
stormi
approved these changes
Oct 6, 2023
Previous code structure was that of 2 nested if's, with nominal code path being in the positive branch of each if. Adding another condition will bring a need for logging the reason to ignore a backup, but doing that by converting inner `if` to an `elif` chain (arguably the simplest modification) would bring the nominal code path to switch to the negative/last branch of the inner `elif` chain. At the same time, the outer `if` would not seem special enough to deserve it special place (and the cyclomatic complexity). This commit leverages the existing `try:except:` block to switch to an "error out the loop" pattern, where the nominal code path is just linear. Using `StopIteration` may feel like an abuse, but: - it is the only standard `Exception` that is not a `StandardError` or a `Warning`, and defining a new one could seem overkill - the closest alternative would be a `while True` loop and breaking out in both exceptional code paths and at the end of nominal path, where the `break` statements would "stop the iteration" as well Signed-off-by: Yann Dirson <[email protected]>
…rver#66) Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
inexistant-disks
branch
from
9771df0 to
7a99335
Compare
stormi
approved these changes
Oct 9, 2023
ydirson
added a commit
that referenced
this pull request
Dec 15, 2023
Don't fail seeing a backup refering to non-existent disk
ydirson
added a commit
that referenced
this pull request
Apr 18, 2024
Don't fail seeing a backup refering to non-existent disk
ydirson
added a commit
that referenced
this pull request
Apr 19, 2024
Don't fail seeing a backup refering to non-existent disk
ydirson
added a commit
that referenced
this pull request
Apr 19, 2024
Don't fail seeing a backup refering to non-existent disk
ydirson
added a commit
that referenced
this pull request
Apr 19, 2024
Don't fail seeing a backup refering to non-existent disk
ydirson
added a commit
that referenced
this pull request
Jul 2, 2024
Don't fail seeing a backup refering to non-existent disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code submitted as xenserver#70 (formerly xenserver#67)