Enhance tracing to hunt for restore bug #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormi
approved these changes
Jul 31, 2024
The particular issue turned out to be that the nested UEFI host being restored had several disks attached. Since this is done as NVMe namespaces of a single disk, all sharing the same ID, udev in dom0 does not have enough info and messes up /dev/disk/by-id/ on which restore relies because of /etc/xensource-inventory: lrwxrwxrwx 1 root root 13 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0 -> ../../nvme0n3 lrwxrwxrwx 1 root root 15 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0-part1 -> ../../nvme0n2p1 lrwxrwxrwx 1 root root 15 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0-part2 -> ../../nvme0n1p2 Only the addition of the `tool.dump()` call allowed me to connect the "Failed to create root filesystem" error with that longstanding (in)famous issue, but a few other additions were useful to get there. Signed-off-by: Yann Dirson <[email protected]> (cherry picked from commit 02d72e6, with one additional safety guard that does not apply to master any more)
ydirson
force-pushed
the
xs8/enhance-traces
branch
from
f1b2f28 to
fd1a6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is xenserver#157 for xcp-ng 8.3.0