Skip to content

Commit

Permalink
Remove CoInstaller from INF
Browse files Browse the repository at this point in the history
Windows 11 22H2 WHQL requires INF files pass "InfVerif /k", which highlights
several issues
- PnpLockdown=1 needs to be specified
- CoInstallers are no longer allowed

The CoInstaller has several functions that will need alternative solutions:
- The AllowUpdate mechanism is no longer possible
- The safety checks that ensure interface versionings remain compatible

Interface safety checks need to be handled by changes to child device bindings,
and assuming upgrade via emulated devices is safe.

Signed-off-by: Owen Smith <[email protected]>
  • Loading branch information
OwenSmi authored and Paul Durrant committed Oct 2, 2023
1 parent db7d41c commit d68b466
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/xenhid.inf
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,16 @@ Provider=%Vendor%
CatalogFile=xenhid.cat
DriverVer=@INF_DATE@,@MAJOR_VERSION@.@MINOR_VERSION@.@MICRO_VERSION@.@BUILD_NUMBER@
DriverPackageDisplayName=%DiskDesc%
PnpLockdown=1

[DestinationDirs]
DefaultDestDir=12
CoInst_CopyFiles=11

[SourceDisksNames]
0=%DiskDesc%

[SourceDisksFiles]
xenhid.sys=0,,
xenhid_coinst.dll=0,,

[CoInst_CopyFiles]
xenhid_coinst_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@[email protected],xenhid_coinst.dll

[Manufacturer]
%Vendor%=Inst,NT@INF_ARCH@
Expand Down Expand Up @@ -85,13 +81,6 @@ AddReg = XenHid_Parameters
HKR,"Parameters",,0x00000010
HKR,"Parameters","RequestKey",0x00000000,%RequestKey%

[XenHid_Inst.CoInstallers]
CopyFiles=CoInst_CopyFiles
AddReg=CoInst_AddReg

[CoInst_AddReg]
HKR,,CoInstallers32,0x00010000,"xenhid_coinst_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@[email protected],Entry"

[Strings]

Vendor="@VENDOR_NAME@"
Expand Down

0 comments on commit d68b466

Please sign in to comment.