Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute quicktest for each SM driver #133

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Execute quicktest for each SM driver #133

merged 1 commit into from
Jan 19, 2024

Conversation

Wescoeur
Copy link
Member

Signed-off-by: Ronan Abhamon [email protected]

@Wescoeur Wescoeur requested review from stormi and gduperrey July 27, 2022 08:10
@Wescoeur Wescoeur force-pushed the ran-storage-quicktest branch from a26153f to e5d1704 Compare July 27, 2022 08:11
stormi
stormi reviewed Jul 29, 2022
View reviewed changes
tests/storage/storage.py Outdated Show resolved Hide resolved
@Wescoeur Wescoeur force-pushed the ran-storage-quicktest branch from e5d1704 to 8bd3916 Compare July 29, 2022 12:41
@stormi
Copy link
Member

stormi commented Aug 2, 2022

The latest update candidate for xapi-tests will fix the behaviour of the -default-sr parameter of quicktest. You can install it on the hosts to test your PR.

@gthvn1 gthvn1 force-pushed the ran-storage-quicktest branch 2 times, most recently from 3264e70 to 269e94e Compare August 2, 2023 08:10
benjamreis
benjamreis requested changes Sep 22, 2023
View reviewed changes
tests/storage/fsp/test_fsp_sr.py Outdated Show resolved Hide resolved
@stormi
Copy link
Member

stormi commented Sep 22, 2023

This PR has had a force push last month, but it's still named "[WIP]", and no re-review was requested. What's the current status?

@benjamreis
Copy link
Contributor

IIRC we were waiting for new sources from XAPI to include the quicktest --sr option and from smapi to have the proper test filter applied.

@stormi
Copy link
Member

stormi commented Sep 22, 2023 •
edited
Loading

As far as I know, we have already patched and built XAPI with these patches, both in XCP-ng 8.2 and 8.3, I had Gaël run CI on them to make sure nothing regressed, and all we are waiting for is this PR.

@stormi
Copy link
Member

stormi commented Sep 22, 2023

Maybe I'm wrong, since you are the ones leading this development, but in my view I was waiting for you to tell me: this PR is good, you can review it.

@gthvn1
Copy link
Contributor

gthvn1 commented Sep 23, 2023 •
edited
Loading

Ooops sorry yes I back ported the patch from upstream to allow user to select the SR using the option.
As this patch is the work of @Wescoeur I will let him modify the title and remove the WIP and check if everything is OK but for me it is ready for reviewing.
EDITED: Fix for ZFS and static vdis have been backported as well. So quicktest should pass now.

benjamreis
benjamreis requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@benjamreis benjamreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also do we remove the tests/quicktest since now it is launched for each driver?

tests/storage/fsp/test_fsp_sr.py Outdated Show resolved Hide resolved
@benjamreis benjamreis changed the title [WIP] Execute quicktest for each SM driver Execute quicktest for each SM driver Sep 25, 2023
@Wescoeur
Copy link
Member Author

As this patch is the work of @Wescoeur I will let him modify the title and remove the WIP and check if everything is OK but for me it is ready for reviewing.

Because I don't work on that, you can freely modify whatever you want. :)

@benjamreis benjamreis force-pushed the ran-storage-quicktest branch 3 times, most recently from 46ad78c to 13f9319 Compare September 28, 2023 08:00
stormi
stormi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next step, before merging: run the tests several times in a row to try to ensure they are stable.

tests/storage/storage.py Outdated Show resolved Hide resolved
@stormi stormi force-pushed the ran-storage-quicktest branch from 13f9319 to b17276a Compare October 3, 2023 10:11
@stormi
Copy link
Member

stormi commented Oct 3, 2023

Rebased on master branch

@benjamreis benjamreis force-pushed the ran-storage-quicktest branch from e6488a8 to 806c732 Compare October 4, 2023 08:14
@benjamreis benjamreis force-pushed the ran-storage-quicktest branch from 7637a43 to f8fe13e Compare January 12, 2024 13:52
@Wescoeur @benjamreis
Execute quicktest for each SM driver
4e449dd 
- Use the `-sr` option of quicktest to run it on a specific SR
- Remove plain quicktest test that ran it at once on all SRs available
- Remove `quicktest` job as the test no longer exists

Co-authored-by: Guillaume Thouvenin <[email protected]>
Co-authored-by: Benjamin Reis <[email protected]>
Signed-off-by: Ronan Abhamon <[email protected]>
@benjamreis benjamreis force-pushed the ran-storage-quicktest branch from 64ca634 to 4e449dd Compare January 19, 2024 14:13
@benjamreis benjamreis merged commit 65ce81d into master Jan 19, 2024
4 checks passed
@benjamreis benjamreis deleted the ran-storage-quicktest branch January 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamreis benjamreis benjamreis approved these changes

@gthvn1 gthvn1 gthvn1 approved these changes

@stormi stormi stormi approved these changes

@gduperrey gduperrey gduperrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wescoeur @stormi @benjamreis @gthvn1 @gduperrey