Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use XO for migration tests #193

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Do not use XO for migration tests #193

merged 4 commits into from
Jan 25, 2024

Conversation

benjamreis
Copy link
Contributor

No description provided.

gthvn1
gthvn1 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gthvn1 gthvn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment otherwise it looks good

lib/vm.py Outdated Show resolved Hide resolved
@benjamreis benjamreis force-pushed the migrate-without-xo branch 5 times, most recently from 1c41b55 to fe55af6 Compare January 23, 2024 10:42
stormi
stormi reviewed Jan 23, 2024
View reviewed changes
lib/host.py Outdated Show resolved Hide resolved
stormi
stormi reviewed Jan 23, 2024
View reviewed changes
lib/vm.py Show resolved Hide resolved
@benjamreis benjamreis requested a review from stormi January 23, 2024 13:38
stormi
stormi reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message for the second commit is not accurate anymore, and there's a small typo in the third commit message: dependancy => dependency.

lib/host.py Outdated Show resolved Hide resolved
lib/vm.py Outdated Show resolved Hide resolved
@benjamreis benjamreis requested a review from stormi January 24, 2024 20:47
@gduperrey
Copy link
Member

I did a full run with this branch on 8.2: ✅

@benjamreis
Use 'xe' for VM migration instead of 'xo_cli'
7e7bb18 
- Support dict as args in xe method

Signed-off-by: Benjamin Reis <[email protected]>
@benjamreis
Remove dependency to XO in migration tests
505e3b4 
Signed-off-by: Benjamin Reis <[email protected]>
@benjamreis
Add a test for connection XO to hosts
1b8ba95 
Signed-off-by: Benjamin Reis <[email protected]>
@stormi stormi merged commit 65f75c3 into master Jan 25, 2024
4 checks passed
@stormi stormi deleted the migrate-without-xo branch January 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthvn1 gthvn1 gthvn1 approved these changes

@stormi stormi stormi approved these changes

@Wescoeur Wescoeur Wescoeur approved these changes

@gduperrey gduperrey gduperrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjamreis @gduperrey @gthvn1 @stormi @Wescoeur