jobs.py: Fix subprocess.run() output capture #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gduperrey
approved these changes
Mar 4, 2024
The 'capture_output' and 'text' parameters for subprocess.run() have been introduced in python 3.7. This change uses 'stdout=subprocess.PIPE' instead for our Jenkins server running python 3.6. Also print more information about 'lsb_release' possible failure and the host version under test. Signed-off-by: Thierry Escande <[email protected]>
tescande
force-pushed
the
fix/jobs.py_subprocess_output_capture
branch
from
de67be8 to
d998b6b
Compare
stormi
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'capture_output' prameter for subprocess.run() has been introduced in python 3.7. Use 'stdout=subprocess.PIPE' and 'stderr=subprocess.PIPE' instead for our Jenkins server running python 3.6.
Also print more information about the host version under test.