Fix ssh command and update documentation #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change imports and uses lib.commands.ssh() function instead of calling subprocess.run() as the ssh() function handles various corner cases and ssh options. Signed-off-by: Thierry Escande <[email protected]>
tescande
force-pushed
the
fix/ssh_command
branch
from
81c7b51 to
59ea49f
Compare
stormi
approved these changes
Mar 4, 2024
gduperrey
approved these changes
Mar 4, 2024
This change specifies that raw strings must be used for the host version regular expression patterns in vm_data.py (i.e. r"PATTERN"). This corrects warning about invalid escaped sequences. Signed-off-by: Thierry Escande <[email protected]>
tescande
force-pushed
the
fix/ssh_command
branch
from
59ea49f to
265e754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.