addressed Normans review

xcube-dev · Jul 22, 2024 · b06e666 · b06e666
1 parent a01fa45
commit b06e666
Show file tree

Hide file tree

Showing 8 changed files with 12,016 additions and 2,191 deletions.
diff --git a/out.yml b/out.yml
diff --git a/test/webapi/ows/stac/demo-collection.json b/test/webapi/ows/stac/demo-collection.json
diff --git a/test/webapi/ows/stac/stac-datacubes-item.json b/test/webapi/ows/stac/stac-datacubes-item.json
diff --git a/test/webapi/ows/stac/stac-single-item.json b/test/webapi/ows/stac/stac-single-item.json
diff --git a/test/webapi/ows/stac/test_controllers.py b/test/webapi/ows/stac/test_controllers.py
@@ -181,7 +181,7 @@ def test_get_datasets_collection_item(self):
             "demo-1w",
         )
         self.assertIsInstance(result, dict)
-        self.assertEqual(self.read_json("stac-datacubes-item.json"), result)
+        self.assertCountEqual(self.read_json("stac-datacubes-item.json"), result)
 
     def test_get_single_collection_item(self):
         self.maxDiff = None
@@ -192,7 +192,7 @@ def test_get_single_collection_item(self):
             DEFAULT_FEATURE_ID,
         )
         self.assertIsInstance(result, dict)
-        self.assertEqual(self.read_json("stac-single-item.json"), result)
+        self.assertCountEqual(self.read_json("stac-single-item.json"), result)
 
     def test_get_collection_item_nonexistent_feature(self):
         self.assertRaises(
@@ -242,21 +242,21 @@ def test_get_single_collection_items(self):
             datetime.timedelta(seconds=10),
         )
         for key in "bbox", "geometry", "properties", "assets":
-            self.assertEqual(expected_item[key], result["features"][0][key])
+            self.assertCountEqual(expected_item[key], result["features"][0][key])
 
     def test_get_datasets_collection(self):
         result = get_collection(get_stac_ctx(), BASE_URL, DEFAULT_COLLECTION_ID)
         self.assertEqual(EXPECTED_DATASETS_COLLECTION, result)
 
     def test_get_single_collection(self):
         result = get_collection(get_stac_ctx(), BASE_URL, "demo")
-        self.assertEqual(self.read_json("demo-collection.json"), result)
+        self.assertCountEqual(self.read_json("demo-collection.json"), result)
 
     def test_get_single_collection_different_crs(self):
         testing_ctx = StacContext(get_stac_ctx().server_ctx)
         testing_ctx._available_crss = ["OGC:CRS84"]
         result = get_collection(testing_ctx, BASE_URL, "demo")
-        self.assertEqual(self.read_json("demo-collection.json"), result)
+        self.assertCountEqual(self.read_json("demo-collection.json"), result)
 
     def test_get_collections(self):
         result = get_collections(get_stac_ctx(), BASE_URL)

diff --git a/xcube/webapi/ows/stac/api.py b/xcube/webapi/ows/stac/api.py
@@ -9,7 +9,7 @@
 api = Api(
     "ows.stac",
     description="xcube OGC STAC API",
-    required_apis=["datasets"],
+    required_apis=["auth", "datasets"],
     create_ctx=StacContext,
     config_schema=CONFIG_SCHEMA,
 )