Cleanup in module xcube.core.varexpr
#1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstntokas
approved these changes
Jul 15, 2024
| class VarExprValidator(ast.NodeTransformer): | ||
| def visit_Lambda(self, node): | ||
| raise VarExprError("lambda expressions are not supported") | ||
| def _format_callable(name: str, fn: Union[np.ufunc, Callable]): |
There was a problem hiding this comment.
What is the reason for putting this outside of the class?
There was a problem hiding this comment.
It is was a private static method and now it is a private function, calling is shorter as it does not require context object.
No, this code and the former has not been released yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup in module
xcube.core.varexprChecklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*Changes documented inCHANGES.md