Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes/updates to AppVeyor/micromamba config #1051

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jul 24, 2024

Closes #1050 .

  • Use current official/canonical URLs to fetch micromamba binaries (old ones still work at present, but might break in future).

  • Fetch with curl, not wget, on Ubuntu. No change in functionality, but this makes it consistent with the Mac config so easier to understand and maintain.

  • Add missing --root-prefix parameter to the micromamba shell invocation. Previously we used the synonymous -p parameter for this, but this will be retired in the upcoming micromamba 2.0 release (see https://mamba.readthedocs.io/en/latest/developer_zone/changes-2.0.html#micromamba ).

  • Execute micromamba.sh, not mamba.sh, as the profile set-up script (since the latter is not found).

Checklist:

  • [ ] Add unit tests and/or doctests in docstrings n/a
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions n/a
  • [ ] New/modified features documented in docs/source/* n/a
  • [ ] Changes documented in CHANGES.md n/a
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

- Use current official/canonical URLs to fetch micromamba binaries (old
  ones still work at present, but might break in future).

- Fetch with curl, not wget, on Ubuntu. No change in functionality, but
  this makes it consistent with the Mac config so easier to understand
  and maintain.

- Add missing --root-prefix parameter to the `micromamba shell`
  invocation. Previously we used the synonymous -p parameter for this,
  but this will be retired in the upcoming micromamba 2.0 release
  (see
  https://mamba.readthedocs.io/en/latest/developer_zone/changes-2.0.html#micromamba
  ).

- Execute micromamba.sh, not mamba.sh, as the profile set-up script
  (since the latter is not found).
@konstntokas konstntokas self-requested a review July 25, 2024 07:50
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I removed the -p flag and the root prefix turned into an argument but using --root-prefixincreases readability. I did not check for the URL updates. So, cool that looked into it. :)

@konstntokas konstntokas merged commit c3b2e42 into main Jul 25, 2024
4 checks passed
@konstntokas konstntokas deleted the pont-1050-fix-ci branch July 25, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppVeyor builds broken
2 participants