Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New endpoints for managing viewer state #1091

Merged
merged 6 commits into from
Nov 20, 2024
Merged

New endpoints for managing viewer state #1091

merged 6 commits into from
Nov 20, 2024

Conversation

forman
Copy link
Member

@forman forman commented Nov 15, 2024 •
edited
Loading

Closes #1088

See xcube-dev/xcube-viewer#449

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this Nov 15, 2024
@forman forman marked this pull request as ready for review November 18, 2024 12:34
@forman forman marked this pull request as draft November 18, 2024 12:35
@forman forman marked this pull request as ready for review November 18, 2024 12:41
@forman forman mentioned this pull request Nov 18, 2024
Merged
4 tasks
b-yogesh
b-yogesh requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please review the suggested changes.

docs/source/cli/xcube_serve.rst Outdated Show resolved Hide resolved
docs/source/cli/xcube_serve.rst Show resolved Hide resolved
xcube/webapi/viewer/context.py Show resolved Hide resolved
xcube/webapi/viewer/routes.py Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
AliceBalfanz
AliceBalfanz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from a user perspective, tested caching in memory. Works well :)

@forman forman requested a review from b-yogesh November 20, 2024 08:59
@forman forman merged commit 133cbb1 into main Nov 20, 2024
2 of 3 checks passed
@forman forman deleted the forman-1088-permalink_service branch November 20, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-yogesh b-yogesh b-yogesh approved these changes

@AliceBalfanz AliceBalfanz AliceBalfanz approved these changes

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide permalink service to xcube Viewer
3 participants
@forman @b-yogesh @AliceBalfanz