Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin zarr dependency to <3 #1103

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Pin zarr dependency to <3 #1103

merged 1 commit into from
Jan 10, 2025

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jan 10, 2025

Closes #1102

Checklist:

  • [ ] Add unit tests and/or doctests in docstrings n/a
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions n/a
  • [ ] New/modified features documented in docs/source/* n/a
  • [ ] Changes documented in CHANGES.md n/a
  • GitHub CI passes *
  • AppVeyor CI passes *
  • Test coverage remains or increases (target 100%)

* There are two test failures:

FAILED test/core/gen2/test_progress.py::TestThreadedProgressObservers::test_threaded_progress_on_begin - RuntimeError: Patch is already started
FAILED test/core/gen2/test_progress.py::TestThreadedProgressObservers::test_threaded_progress_on_end - RuntimeError: Patch is already started

But these have already been failing in main for a while and are nothing to do with this PR.

@pont-us pont-us merged commit e792d49 into main Jan 10, 2025
1 of 4 checks passed
@pont-us pont-us deleted the pont-1102-pin-zarr-2 branch January 10, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin Zarr dependency to version <3
1 participant