Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in TestThreadedProgressObservers tests #1105

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jan 10, 2025

test_threaded_progress_on_begin and test_threaded_progress_on_end were calling stop() on _patch rather than _mock_patch(), producing an error on the subsequent _mock_patch.start() (since it was already started, and hadn't been stopped). Corrected in this commit.

Fixes #1104

[Description of PR]

Checklist:

  • [ ] Add unit tests and/or doctests in docstrings n/a
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions n/a
  • [ ] New/modified features documented in docs/source/* n/a
  • [ ] Changes documented in CHANGES.md n/a
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

test_threaded_progress_on_begin and test_threaded_progress_on_end
were calling stop() on _patch rather than _mock_patch(), producing
an error on the subsequent _mock_patch.start() (since it was
already started, and hadn't been stopped). Corrected in this commit.

Fixes #1104
@pont-us pont-us self-assigned this Jan 10, 2025
@pont-us pont-us requested a review from forman January 10, 2025 17:00
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (2c02ea2) to head (32dc1ed).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
- Coverage   89.94%   89.58%   -0.37%     
==========================================
  Files         276      277       +1     
  Lines       21573    21836     +263     
==========================================
+ Hits        19404    19561     +157     
- Misses       2169     2275     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pont-us pont-us merged commit 393697f into main Jan 13, 2025
4 of 5 checks passed
@pont-us pont-us deleted the pont-1104-progress-observers branch January 13, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two TestThreadedProgressObservers unit tests failing
2 participants