-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing GitHub CI #899 #918
Conversation
…dlessly if the server does not start properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective. Approved with a minor language nitpick.
Co-authored-by: Pontus Lurcock <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 93.43% 93.43% -0.01%
==========================================
Files 453 453
Lines 35510 35518 +8
==========================================
+ Hits 33180 33186 +6
- Misses 2330 2332 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this rather as a workaround than a proper fix. In line 59, we instantiate an AnyThreadEventLoopPolicy which has been deprecated (see https://www.tornadoweb.org/en/stable/asyncio.html#tornado.platform.asyncio.AnyThreadEventLoopPolicy). I assume we'd need to remove this and that we still will encounter issues in the future. I approve this PR as it solves our momentary problems, but I suggest not to close the issue.
This PR fixes #899. The reason for the test failures in GitHub has been a race condition: the server starts in the background, and on another thread, the tests use it. The fix ensured that the server has started before the setUp() method terminates.
The checklist items below do not apply mostly, as there are no new features to be documented.
Checklist:
docs/source/*
CHANGES.md