dialects: (builtin) integer bitwidths must not be negative (#3799)

xdslproject · Jan 29, 2025 · 6cdfb16 · 6cdfb16
1 parent 2c234ab
commit 6cdfb16
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/tests/dialects/test_builtin.py b/tests/dialects/test_builtin.py
@@ -72,6 +72,12 @@ def test_FloatType_formats():
         Float128Type().format
 
 
+def test_IntegerType_verifier():
+    IntegerType(32)
+    with pytest.raises(VerifyException):
+        IntegerType(-1)
+
+
 def test_IntegerType_formats():
     assert IntegerType(1).format == "<b"
     assert IntegerType(2).format == "<b"

diff --git a/xdsl/dialects/builtin.py b/xdsl/dialects/builtin.py
@@ -478,6 +478,12 @@ def __init__(
             signedness = SignednessAttr(signedness)
         super().__init__([data, signedness])
 
+    def verify(self):
+        if self.width.data < 0:
+            raise VerifyException(
+                f"integer type bitwidth should be nonnegative (got {self.width.data})"
+            )
+
     def value_range(self) -> tuple[int, int]:
         return self.signedness.data.value_range(self.width.data)