Skip to content

Commit

Permalink
CI: fail CI if lockfile is out of sync with project (#3639)
Browse files Browse the repository at this point in the history
We also want to automate the updating of the lockfile, but I think this
also helps make sure that they're always in sync before merging, in case
someone updates the dependency locally.

The version overloading is related to this issue in uv, which is that it
doesn't have an official mechanism to support dynamic versions:
astral-sh/uv#7533
  • Loading branch information
superlopuh authored Dec 16, 2024
1 parent 52d4f1c commit 7c4cb63
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 3 deletions.
38 changes: 38 additions & 0 deletions .github/workflows/ci-lockfile.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: CI - Lockfile

on:
# Trigger the workflow on push or pull request,
# but only for the master branch
push:
branches:
- main
pull_request:

jobs:
build:

runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.12']

steps:
- uses: actions/checkout@v4

- name: Install uv
uses: astral-sh/setup-uv@v3
with:
enable-cache: true
cache-dependency-glob: "uv.lock"

- name: Set up Python ${{ matrix.python-version }}
run: uv python install ${{ matrix.python-version }}

- name: Install the package locally and check for lockfile mismatch
run: |
# Install all default extras.
# Fail if the lockfile dependencies are out of date with pyproject.toml.
XDSL_VERSION_OVERRIDE="0+dynamic" uv sync --extra gui --extra dev --extra jax --extra riscv --locked
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ uv-installed:
# set up the venv with all dependencies for development
.PHONY: ${VENV_DIR}/
${VENV_DIR}/: uv-installed
uv sync ${VENV_EXTRAS}
XDSL_VERSION_OVERRIDE="0+dynamic" uv sync ${VENV_EXTRAS}

# make sure `make venv` also works correctly
.PHONY: venv
Expand Down
9 changes: 8 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import os
from collections.abc import Mapping
from typing import cast

from setuptools import Command, find_packages, setup

import versioneer

if "XDSL_VERSION_OVERRIDE" in os.environ:
version = os.environ["XDSL_VERSION_OVERRIDE"]
else:
version = versioneer.get_version()


setup(
version=versioneer.get_version(),
version=version,
cmdclass=cast(Mapping[str, type[Command]], versioneer.get_cmdclass()),
packages=find_packages(),
)
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7c4cb63

Please sign in to comment.