refactor: union and issuperset

xdslproject · Jan 24, 2025 · ad87012 · ad87012
1 parent e49877b
commit ad87012
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/xdsl/irdl/declarative_assembly_format.py b/xdsl/irdl/declarative_assembly_format.py
@@ -445,14 +445,13 @@ def print(self, printer: Printer, state: PrintingState, op: IRDLOperation) -> No
                 )
             op_def = op.get_irdl_definition()
             dictionary = op.attributes | op.properties
-            default_names = set(
+            reserved_or_default = self.reserved_attr_names.union(
                 name
                 for name, d in (op_def.properties | op_def.attributes).items()
                 if d.default_value is not None
                 and dictionary.get(name) == d.default_value
             )
-            reserved_or_default = self.reserved_attr_names | default_names
-            if not (set(dictionary.keys())) - reserved_or_default:
+            if reserved_or_default.issuperset(dictionary.keys()):
                 return
             printer.print_op_attributes(
                 dictionary,
@@ -461,14 +460,13 @@ def print(self, printer: Printer, state: PrintingState, op: IRDLOperation) -> No
             )
         else:
             op_def = op.get_irdl_definition()
-            default_names = set(
+            reserved_or_default = self.reserved_attr_names.union(
                 name
                 for name, d in op_def.attributes.items()
                 if d.default_value is not None
                 and op.attributes.get(name) == d.default_value
             )
-            reserved_or_default = self.reserved_attr_names | default_names
-            if not set(op.attributes.keys()) - reserved_or_default:
+            if reserved_or_default.issuperset(op.attributes.keys()):
                 return
             printer.print_op_attributes(
                 op.attributes,