-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Introduce integer constraints #3699
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
==========================================
- Coverage 91.31% 91.31% -0.01%
==========================================
Files 467 467
Lines 58487 58586 +99
Branches 5640 5645 +5
==========================================
+ Hits 53406 53495 +89
- Misses 3632 3640 +8
- Partials 1449 1451 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, that looks good to me!
Hopefully we can encode some constraints for variadics with it ;)
@math-fehr the idea was that this is an alternative to #3698, did you have any preferences between the two. |
I vote this one as it allows you to have different input and output types in the example given. |
@math-fehr any thoughts? I'm hoping that this version should be able to encode some constraints for shaped types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this one
I'll merge this PR in a couple of hours unless anyone else has comments |
Sorry, I am overwhelmed work-wise recently, so I missed your question! |
This would probably make #3698 obsolete, as it covers the one use case of that PR that I can think of. This is a bit more of an involved change but I feel that there are some interesting a powerful things you could do with this in the future.
Would likely need a few more tests if we want to go with this.