Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Introduce integer constraints #3699

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

alexarice
Copy link
Collaborator

This would probably make #3698 obsolete, as it covers the one use case of that PR that I can think of. This is a bit more of an involved change but I feel that there are some interesting a powerful things you could do with this in the future.

Would likely need a few more tests if we want to go with this.

@alexarice alexarice added the core xDSL core (ir, textual format, ...) label Jan 6, 2025
@alexarice alexarice self-assigned this Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (b83ddb2) to head (6135f83).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3699      +/-   ##
==========================================
- Coverage   91.31%   91.31%   -0.01%     
==========================================
  Files         467      467              
  Lines       58487    58586      +99     
  Branches     5640     5645       +5     
==========================================
+ Hits        53406    53495      +89     
- Misses       3632     3640       +8     
- Partials     1449     1451       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, that looks good to me!
Hopefully we can encode some constraints for variadics with it ;)

@alexarice
Copy link
Collaborator Author

@math-fehr the idea was that this is an alternative to #3698, did you have any preferences between the two.

@kimxworrall
Copy link
Collaborator

I vote this one as it allows you to have different input and output types in the example given.

@alexarice
Copy link
Collaborator Author

@math-fehr any thoughts? I'm hoping that this version should be able to encode some constraints for shaped types.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this one

@alexarice
Copy link
Collaborator Author

I'll merge this PR in a couple of hours unless anyone else has comments

@math-fehr
Copy link
Collaborator

Sorry, I am overwhelmed work-wise recently, so I missed your question!
I do prefer that one :)

@alexarice alexarice merged commit bac3115 into main Jan 24, 2025
16 checks passed
@alexarice alexarice deleted the alexarice/int-constraints branch January 24, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants