dialects: (onnx) remove ONNX-related code #3738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
alexarice,
math-fehr,
EdmundGoodman and
webmiche
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3738 +/- ##
==========================================
- Coverage 91.30% 91.24% -0.06%
==========================================
Files 468 459 -9
Lines 58636 57358 -1278
Branches 5656 5536 -120
==========================================
- Hits 53535 52338 -1197
+ Misses 3650 3591 -59
+ Partials 1451 1429 -22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX, which I was hoping would be a convenient way to define NNs in Python to then compile using xDSL, has proven to be a massive maintenance burden, and generally not very good. They are slow to support new Python versions, poor typing support, and the import mechanism is not very stable, so I couldn't even reliably import networks. Our code for it is fairly buggy, and the bug fixes weren't all merged before Kayode finished his masters project.
Given Quidditch and IREE's support for importing ONNX, I don't see the point of having our implementation in xDSL, hence this PR.