Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: (ContainerOf) improve python typing #3800

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

alexarice
Copy link
Collaborator

Improves the python typing bounds on the ContainerOf constraint.

@alexarice alexarice added the core xDSL core (ir, textual format, ...) label Jan 29, 2025
@alexarice alexarice self-assigned this Jan 29, 2025
@alexarice
Copy link
Collaborator Author

alexarice commented Jan 29, 2025

Nevermind this breaks a load of stuff (seems pyright didn't run locally) fixed

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (fa315a7) to head (c047943).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3800      +/-   ##
==========================================
- Coverage   91.23%   91.23%   -0.01%     
==========================================
  Files         461      461              
  Lines       57480    57487       +7     
  Branches     5547     5548       +1     
==========================================
+ Hits        52443    52449       +6     
  Misses       3615     3615              
- Partials     1422     1423       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

I like this a lot

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@alexarice alexarice merged commit 2338bb0 into main Jan 29, 2025
16 checks passed
@alexarice alexarice deleted the alexarice/container-of-typing branch January 29, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants