Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: move frontend desymref test to custom format #3813

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

superlopuh
Copy link
Member

It's not very clear from the diff, but here are the changes:

  1. remove the outer builtin.module and dedent
  2. move check lines above inputs
  3. move everything to custom syntax

@superlopuh superlopuh added the testing PRs that modify tests label Jan 31, 2025
@superlopuh superlopuh self-assigned this Jan 31, 2025
Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we need this in many places.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (5934e29) to head (d618da8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3813   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         461      461           
  Lines       57557    57557           
  Branches     5549     5549           
=======================================
  Hits        52523    52523           
  Misses       3609     3609           
  Partials     1425     1425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit bd5575d into main Jan 31, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/frontend/custom-syntax-tests branch January 31, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants